Skip to content

NodeClient does not work fully without creating via init #11118

Closed

Description

@timfish

Problem Statement

initOtel is only called from init and it's not exported. This means that the NodeClient on it's own does not support otel.

Solution Brainstorm

Call initOtel from the client.

Activity

  1. mydea commented on Mar 15, 2024

    @mydea
    Member

    Hmm, good point! I think I'd vote, for now, to export this method (under a better name, e.g. initOpenTelemetry() or something like this) for now 🤔

  2. timfish commented on Mar 15, 2024

    @timfish
    CollaboratorAuthor

    and allow passing the client initOpenTelemetry(client) so it works with not only the global client?

  3. mydea commented on Mar 15, 2024

    @mydea
    Member

    yeah, that sounds like a good idea - probably require passing the client in, actually, I think that makes more sense!

  4. timfish commented on Mar 16, 2024

    @timfish
    CollaboratorAuthor

    Am I correct in my understanding that we only need to initOpenTelemetry if tracing is enabled?

  5. added a commit that references this issue on Mar 18, 2024
    b9c060a
  6. added a commit that references this issue on Apr 19, 2024
    1e53829
  7. ghost added on Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions