Skip to content

[v8] Refactor usages of span.startChild() to startInactiveSpan() #10900

Closed

Description

@mydea

We have some leftover usages of span.startChild(). Some of them are related to #10898, but others are standalone and should be refactored to just create a span based on the active span.

In most cases, we can probably refactor them to just use startInactiveSpan instead, unless we need the span to be active (which is rarely the case, as far as I could see).

I would ignore the usage in old node for now, we can remove this eventually.

### Tasks
- [ ] https://github.com/getsentry/sentry-javascript/pull/10956
- [ ] https://github.com/getsentry/sentry-javascript/pull/10943
- [x] MAYBE: Refactor `startChild` usage in node & node performance integrations - probably safe to ignore this for now

Activity

  1. changed the title [-][v8] Refactor usages of `span.startChild`[/-] [+][v8] Refactor usages of `span.startChild()` to `startInactiveSpan()`[/+] on Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions