You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
server runtime captureException event level undefined #10588
Hi @Zih0 thanks for writing in and for opening the PR! Before we review and merge it, can you explain what the consequences of the SDK not setting this default value are in the Sentry UI? Is there something missing? As far as I can tell, our Sentry backend sets a default level if it's not set by the SDK. However, if there's a discrepancy, I think we should fix it as you suggested.
@Lms24 Thank you for your comment!
There was nothing wrong in Sentry UI. 🙂
I need to explain my situation first.
I wanted to use beforeSend to handle the event if the level of the event is 'error' and 'fatal'.
Then, I found that the event's level was coming in from the client side, while the event's level was not coming in from the server side.
So I thought this was a bug, so I opened the issue and PR.
If you don't think this is a bug, you can close the issue. :)
Ahh I see, you're bringing up a good point. Let's try to align the behavior with the browser SDK. I just gave the PR a review. Looks good mostly, let's just fix the test then we can merge it.
Activity
Lms24 commentedon Feb 9, 2024
Hi @Zih0 thanks for writing in and for opening the PR! Before we review and merge it, can you explain what the consequences of the SDK not setting this default value are in the Sentry UI? Is there something missing? As far as I can tell, our Sentry backend sets a default level if it's not set by the SDK. However, if there's a discrepancy, I think we should fix it as you suggested.
Zih0 commentedon Feb 9, 2024
@Lms24 Thank you for your comment!
There was nothing wrong in Sentry UI. 🙂
I need to explain my situation first.
I wanted to use beforeSend to handle the event if the level of the event is 'error' and 'fatal'.
Then, I found that the event's level was coming in from the client side, while the event's level was not coming in from the server side.
So I thought this was a bug, so I opened the issue and PR.
If you don't think this is a bug, you can close the issue. :)
Lms24 commentedon Feb 9, 2024
Ahh I see, you're bringing up a good point. Let's try to align the behavior with the browser SDK. I just gave the PR a review. Looks good mostly, let's just fix the test then we can merge it.
github-actions commentedon Dec 13, 2024
A PR closing this issue has just been released 🚀
This issue was referenced by PR #10587, which was included in the 8.45.0 release.