You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Introduce an optional configurable request timeout #1033
@benvinegar I'm looking at this issue. On the linked PR you mentioned
My only comment is that I'm retiring the current DOM-based event system, which is undocumented, for the event system described in #524 (and implemented in #521).
The unmerged PR seems like it accomplishes the timeout. I do not see the new event system merged into the project. Would it be sufficient if the timeout triggers self._triggerEvent('failure') as i see done in Raven._sendProcessedPayload?
Activity
HeroProtagonist commentedon Oct 16, 2017
@benvinegar I'm looking at this issue. On the linked PR you mentioned
The unmerged PR seems like it accomplishes the timeout. I do not see the new event system merged into the project. Would it be sufficient if the timeout triggers
self._triggerEvent('failure')as i see done inRaven._sendProcessedPayload?kamilogorek commentedon Oct 17, 2017
Per this comment, I believe it should be fine. Although we don't document event system anywhere now, and I'm sure if we will anytime soon.
benvinegar commentedon Oct 25, 2017
+1 that it triggers
failureand more-or-less remains backwards compatible.aravinda0 commentedon Dec 28, 2017
Is there a workaround for this at the moment?
kamilogorek commentedon Jan 9, 2018
@ManiacalAce you can utilize this PR #540 to obtain this behaviour. Instead of forking it, you can use
transportconfig option to modify it. See config docs here https://docs.sentry.io/clients/javascript/config/kamilogorek commentedon Sep 11, 2018
Done through
closemethod in new SDK.