Repository navigation
New session API endSession doesn't include did from initialScope #10146
Description
SDK Version
7.93.0
Steps to Reproduce
The new session API endSession uses the isolationScope session but this does not include the initialScope passed to init.
Expected Result
If initialScope passed to init is set to {user:{username:'some_user'}}, the session did should be some_user.
Actual Result
did is empty.
This is likely because the initialScope is only added to the current hub scope in initAndBind:
sentry-javascript/packages/core/src/sdk.ts
Lines 32 to 35 in 84791bf
Activity
Lms24 commentedon Jan 11, 2024
Hmm I think
endSessionshould check for a session on thecurrentScopefirst and only if there's none fall back to the isolation scope. I didn't think at all aboutinitialScopeand how it's set.This makes me question if we should even set the session on the isolation scope or not just onto the current scope. IIUC, the scope that gets returned from
getCurrentScopeshould anyway be covered by an isolation scope (cc @mydea when you're back).I'll look into this later today.
Also reminder for myself to add an integration test that reproduces this.