Auto-forked startSpan broke retroactive tag addition #10122

Activity

1. jonathroth

   added

   Type: Bug

   on Jan 9, 2024
2. getsantry

   added

   Waiting for: Product Owner

   on Jan 9, 2024
3. getsantry

   added this to GitHub Issues with 👀 2on Jan 9, 2024
4. getsantry

   moved this to Waiting for: Product Owner in GitHub Issues with 👀 2on Jan 9, 2024
5. github-actions

   added

   Package: Browser

   on Jan 9, 2024
6. mydea commented on Jan 10, 2024

   

   mydea

   on Jan 10, 2024

   Member

   More actions

   Hey,

   the previous behavior was accidental and not the expected behavior - calling startSpan should fork the scope and set the current span only on this forked scope, but not change the outer scope. I'm sorry for the confusion this caused!

   If you want to add tags to the general outer scope, you have a few options. In the upcoming v8 release, Sentry.setTag() will always set on the isolation scope, which is basically the outer/global scope.

   For now, in v7, if you want that you can either:

   1. Store the scope before you call startSpan() and set on it later:

   const scope = Sentry.getCurrentScope();
   Sentry.startSpan({ name: 'inner' }, span => {
     scope.setTag(...); // will put it on the outer scope, not in the inner scope!
     // if you _also_ want it on the inner scope, you _also_ need to do
     getCurrentScope().setTag(...);
   });

   2. Put it on the isolation scope directly:

   Sentry.startSpan({ name: 'inner' }, span => {
     getIsolationScope().setTag(...);
     // the isolation scope is applied here, but also to anything outside
     // it is merged with the current scope
   });

   Depending on your concrete needs. The isolation scope is not documented well yet, we are working on this - but TLDR this has been designed exactly for this problem, if you want to add scope data that should be applied everywhere, without having to think about where you are calling this from etc.

   I'm closing this, as the new behavior is the expected behavior - sorry again for the confusion our initially incorrect implementation caused here!

   👍React with 👍1Reacted by Jonathan Roth

   🚀React with 🚀1Reacted by Jonathan Roth
7. mydea

   closed this as not plannedon Jan 10, 2024
8. getsantry

   removed

   Waiting for: Product Owner

   on Jan 10, 2024
9. stephanie-anderson

   added the

   Bug

   issue type on Mar 20, 2025
10. ghost added

    Bug

    on Aug 12, 2025