You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Script won't exit with ANR and captureStackTrace active #10022
Thanks, @timfish . I may have been unclear - #10023 and this issue are separate. #10023 is about unrefing the timer, because "natural" exit doesn't work when ANR is enabled. This issue is about explicit process.exit not working when ANR and captureStackTrace are both enabled.
Activity
timfish commentedon Jan 2, 2024
Thanks for reporting. Sorry, this was unexpected behaviour and therefore didn't even end up in the test cases.
joshkel commentedon Jan 2, 2024
Thanks, @timfish . I may have been unclear - #10023 and this issue are separate. #10023 is about unrefing the timer, because "natural" exit doesn't work when ANR is enabled. This issue is about explicit
process.exitnot working when ANR andcaptureStackTraceare both enabled.timfish commentedon Jan 2, 2024
Ah, thanks for the heads up. I'll test this tomorrow!
timfish commentedon Jan 2, 2024
I couldn't wait but I'll check again tomorrow because it's late...
With the following code and the timer fix, node exits cleanly after a second:
joshkel commentedon Jan 2, 2024
@timfish I apologize; there was a bug in my test case. (That's what I get for trying to do too many things at once...)
I'm seeing the issue with
captureStackTrace: true. I've updated my steps to reproduce.timfish commentedon Jan 2, 2024
Oh, you're right, it doesn't actually fix it with the timer undef'd. The debugger must keep it alive 😬
AbhiPrasad commentedon Jan 4, 2024
All the ANR fixes were released with https://github.com/getsentry/sentry-javascript/releases/tag/7.92.0 - please give it a try!
Thanks for your help + contributions, appreciate it!