Skip to content

[sourcemaps] Exclude CSS maps if excluding CSS files #990

Closed

Description

@lobsterkatie

Environment

sentry-cli version 1.66.0

Steps to Reproduce

Upload sourcemaps with the default extensions set, in a directory with mapped CSS files.

Expected Result

blah.css.map does not get uploaded because blah.css doesn't get uploaded.

Actual Result

blah.css.map does in fact get uploaded.

Notes

  • My show and tell app will work to reproduce this if you need an example to play with.
  • I believe this is because this line just uncritically accepts anything with the extension .map, regardless of what comes before that.

Activity

  1. kamilogorek commented on Oct 14, 2021

    @kamilogorek
    Contributor

    Path extension is always the last segment, so in case of foo.css.map, it would always be .map anyway, so its not trivial to filter it out.
    Instead of implementing it here, I'd say we should add ignore: ['*.css.map'] or other matcher in our Next.js/webpack config, as it's the same format as .gitignore..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions