Repository navigation
feat(replay): Define custom elements (web components) - #87
Merged
Merged
Conversation
Define custom elements so that we the `:defined` pseudo-class works as it can be used as a "loading" indicator while the web component is being loaded. Fixes getsentry/sentry-javascript#7988
billyvg
force-pushed
the
feat-replay-define-custom-elements-shadow-om
branch
from
April 28, 2023 15:05
ed0133c to
49eaad5
Compare
billyvg
marked this pull request as ready for review
April 28, 2023 15:08
Member
|
Hmm, could we add one or two tests for this? 🤔 |
Member
Author
|
@mydea added a test |
mydea
reviewed
May 5, 2023
mydea
approved these changes
May 5, 2023
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 8, 2023
- fix: Fix some input masking (esp for radio buttons) (getsentry/rrweb#85) - fix: Unescaped `:` in CSS rule from Safari (getsentry/rrweb#86) - feat: Define custom elements (web components) (getsentry/rrweb#87)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define custom elements so that we the
:definedpseudo-class works as it can be used as a "loading" indicator while the web component is being loaded.Fixes getsentry/sentry-javascript#7988