This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Repository navigation
fix(breadcrumbs): Ensure maximum lengths on several attributes - #1194
Merged
Merged
Conversation
- Trim message, category, and level attributes - Update pytest support to work in other environments
dcramer
force-pushed
the
fix/trim-crumbs
branch
from
February 2, 2018 23:24
4c1c409 to
ad82e40
Compare
Member
Author
|
This also fixes py.test support which had been broken for me locally. flake8 is still broken (i had to commit with -n) but I dont have time to deal with that. We should be careful changing development/test environment, as it seems we might have done it without considering consequences (e.g. I assume we bumped the version of flake8 and it has never worked w/ our hooks since) |
Member
Author
ashwoods
self-requested a review
February 3, 2018 02:59
ashwoods
reviewed
Feb 3, 2018
| class BreadcrumbBuffer(object): | ||
|
|
||
| def __init__(self, limit=100): | ||
| def __init__(self, limit=100, message_max_length=1024): |
Contributor
There was a problem hiding this comment.
I'll set limit and message_max_length as settings in the new-settings-branch
ashwoods
approved these changes
Feb 3, 2018
Contributor
|
@dcramer Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-604