Repository navigation
fix(updater): Support prefixed release tags - #184
Conversation
vaind
left a comment
There was a problem hiding this comment.
The parsing fix works, and the default pattern keeps existing callers unaffected. Two comments inline: taking the version from a named group in pattern instead of stripping up to the last @, and the changelog links for monorepos like getsentry/toolkit.
Nit: the new changelog test only covers adding an entry, not updating an existing one, which also uses the anchor and display version.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 61a5bfa. Configure here.
vaind
left a comment
There was a problem hiding this comment.
Thanks, this addresses everything from the first round. Three small nits inline, none of them blocking.
The changelog step now takes both the extracted versions from getsentry#184 and the changelog path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Release tags with a product prefix such as
cli@0.47.0(Craft workspaces withtagPrefix, e.g. getsentry/toolkit) are now supported. Callers mark the version part of the tag with aversionnamed group inpattern, e.g.pattern: '^cli@(?<version>[0-9.]+)$'.The group's value is used for version comparison, the changelog anchor and the displayed version, so PR titles and changelog entries read
v0.47.0as for unprefixed tags. The full tag is still used for the dependency version and the compare link, socli@0.46.0...cli@0.47.0resolves on GitHub.update-dependency.ps1outputs the extracted versions asoriginalVersionandlatestVersion, and the action passes them toupdate-changelog.ps1.The current tag is read with the latest tag's prefix, so a tag of another product, e.g. one returned by
git describefor a submodule, is never compared as a version. In that case the changelog entry shows the full old tag, e.g.from logger@0.46.0 to v0.47.0. At-mentions are still removed from the changelog in the PR body, but@after a word character is kept, so prefixed tags and email addresses stay intact.The default
patternbecomes'^v?(?<version>[0-9.]+)$'. Patterns without the group fall back to removing a leadingv, as before, so existing callers are unaffected.Fixes #181