Skip to content

Updater fails for submodule commits outside the default branch #185

Closed

Description

@limbonaut

The updater initializes submodules with --single-branch --no-fetch. If the pinned commit belongs to a separate release branch, checkout can fail because the commit wasn’t downloaded.

The script ignores this failure, reads the wrong current version, and attempts an unnecessary update. With no actual changes, no PR is created, and the job fails with PR hasn't been created.

This happened for gdUnit 6.2.3 in this sentry-godot job.

The updater should allow fetching the pinned commit and stop if checkout fails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions