Skip to content

ROADMAP-18 — P2 — Move test fakes (InMemoryMemoryStore/InMemoryTraceSink) out of production modules #110

Open

Description

@getdownandcode

Series: ROADMAP — filed from the 2026-10-27 whole-project assessment · Backlog task: M16-T05 · Priority: P2 · Effort: small

Problem

InMemoryMemoryStore and InMemoryTraceSink are test doubles that live in production packages (agentkit/memory, agentkit/core). They are the historical reason routes.py/deps.py grew hasattr checks and the reason Agent takes memory: Any (ROADMAP-14 fixes the typing; this issue relocates the fakes themselves). Per the repo's own audit rule, fakes belong under tests/ (or an explicitly documented module).

Evidence

  • agentkit/memory/base.py:80–152 — InMemoryMemoryStore
  • agentkit/core/trace.py:64–78 — InMemoryTraceSink
  • Consumers: examples/, tests/, and (indirectly) the route duck-checks

Suggested fix / acceptance criteria

  • Fakes moved to agentkit/fakes.py (explicitly documented testing module) or tests/ — pick one and note it
  • Import sites updated; prod modules no longer hand out Any-fakes implicitly
  • Suite green

Suggested branch / commit

refactor/fakes-out-of-prod · refactor: move InMemory fakes out of production modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions