Repository navigation
Pierrep/bcloud 14842 - #343
pierrepbitheads wants to merge 5 commits into
Conversation
…. Also added missing authenticateEpicGames, attachEpicGamesIdentity, mergeEpicGamesIdentity and detachEpicGamesIdentity.
# Conflicts: # include/braincloud/BrainCloudIdentity.h
michaelc-bitheads
left a comment
michaelc-bitheads
left a comment
There was a problem hiding this comment.
Same with C#, do we have logs and success/failure callbacks?
|
|
||
| #include <string> | ||
| #include <map> | ||
| #include <functional> |
There was a problem hiding this comment.
Can we not use the existing callback objects?
There was a problem hiding this comment.
Authentication still uses the existing IServerCallback. These new callbacks handle fetching the App Check token before authentication is sent, so their inputs differ from a server response. We can follow the existing callback-object pattern with dedicated App Check interfaces instead of std::function.
|
|
||
| #include "braincloud/BrainCloudAuthentication.h" | ||
| #include <mutex> | ||
| #include <chrono> |
There was a problem hiding this comment.
Surely we can track the time more simply than having to spin up a new thread?
There was a problem hiding this comment.
No new thread is created here. We store the start time with std::chrono::steady_clock and check elapsed time in the existing callback loop. The mutex protects the result if the token provider completes on another thread. We could use an existing SDK timing utility for consistency, but the timeout already works by polling.
|
|
||
| JsonCpp has recently been made a submodule (as of brainCloud 4.15) so if pulling or changing branches the existing folder lib/jsoncpp-1.0.0/ should be deleted or there will be git errors. | ||
|
|
||
| ### Asynchronous App Check token provider |
There was a problem hiding this comment.
I have the same verbosity concern here too.
BCLOUD-14842: Added App Check token and asynchronous token provider to C++ library