Repository navigation
Various fixes needed for HA integration #73
Description
I did a few fixes for my HA integration of E3DC RSCP:
- S10E Serial number detection did not work, a missing elif masked the corresponding check
- A few exported classes were missing (notably SendError for error detection)
- Calls to set_power_save and set_weather_regulated_charge were not correctly parsing the results from E3DC. (Did some code streamlining to those functions on the way)
PR follows in a minute.
Reacted by Eiko Wagenknecht
Activity
torbennehmer commentedon May 9, 2023
Partly fixed by #75
torbennehmer commentedon May 17, 2023
@vchrisb I've got a suggestion: While we figure out, what's up with
set_weather_regulated_chargeon my end: Could we do a release of the fixes in #75? I'd need the Serial Number detection and the missing exceptions for further work on my integration. With Home Assistant, the pye3dc dependency ist automatically loaded from PIP, so I cannot inject some patched version until this resolved even if I'd like to.It would be really great, if this would be officially available :-)