This repository was archived by the owner on Sep 25, 2025. It is now read-only.
Repository navigation
feat: add fieldset and legend in eventForm for screen readers - #2352
Merged
gikf merged 4 commits intoMar 11, 2023
Merged
Conversation
Member
|
Event Type sounds a bit weird to me when describing invite-only event. Not that this isn't technically correct. I don't have idea for what that could be changed. What came to my mind is grouping the Invite only checkbox together with the Capacity and call them both Attendee restrictions or Event restrictions. What do you think? |
Member
Author
|
Sorry, I have missed the comment while I was sick, I am happy with adding the changes. Just to add another option, this change is purely for screen readers, if it isn't visually pleasing, we can add a legend with too many details and set it as visibility hidden. but I don't know what to add as well 🤣. Edit: shouldn't have pushed the latest commit. |
Sboonny
marked this pull request as draft
March 11, 2023 08:06
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Sboonny
force-pushed
the
feat/add-event-type-for-screen-readers
branch
from
March 11, 2023 09:00
5a696a5 to
71c6357
Compare
Sboonny
marked this pull request as ready for review
March 11, 2023 09:01
Sboonny
force-pushed
the
feat/add-event-type-for-screen-readers
branch
from
March 11, 2023 09:22
45759f2 to
e521e3e
Compare
Sboonny
force-pushed
the
feat/add-event-type-for-screen-readers
branch
from
March 11, 2023 09:24
e521e3e to
17c082c
Compare
gikf
approved these changes
Mar 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update README.md).mainbranch of Chapter.Screen Readers may need additional context of what does checking
invite-onlydoes, for now they will know it's the type of the event