This repository was archived by the owner on Sep 25, 2025. It is now read-only.
Repository navigation
feat: filter recent dashboard event - #2285
Merged
Merged
Conversation
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
gikf
reviewed
Jan 27, 2023
gikf
left a comment
gikf
left a comment
Member
There was a problem hiding this comment.
There's couple specific suggestions and a more general ones.
As much as grid helps, buttons sometimes look huge.
The Show recent events might be a bit vague. Recent as only upcoming events?
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Sboonny
commented
Feb 3, 2023
Sboonny
marked this pull request as ready for review
February 3, 2023 11:53
Sboonny
commented
Feb 3, 2023
Sboonny
marked this pull request as draft
February 6, 2023 09:46
Sboonny
marked this pull request as ready for review
February 13, 2023 07:36
Sboonny
marked this pull request as draft
February 13, 2023 08:01
Sboonny
marked this pull request as ready for review
February 13, 2023 10:42
Sboonny
commented
Feb 13, 2023
gikf
reviewed
Feb 13, 2023
gikf
left a comment
gikf
left a comment
Member
There was a problem hiding this comment.
I'm not sure if filtering by default is the way to go. Personally I'd keep the full list on load.
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
gikf
reviewed
Feb 16, 2023
Sboonny
force-pushed
the
feat/filter-recent-event
branch
from
February 16, 2023 18:52
8cf05b2 to
f07e128
Compare
Sboonny
force-pushed
the
feat/filter-recent-event
branch
from
February 16, 2023 18:53
f07e128 to
cfa7655
Compare
gikf
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: gikf 60067306+gikf@users.noreply.github.com
Update README.md).mainbranch of Chapter.Filter recent events on the dashboard, and sorted some styling. It may seem too big of a change, but I haven't done much except make the component compatible with multiple props, and used grid.
The affected page is