Repository navigation
Kill the skeleton dialog's transition on swaps - #492
Open
fredrivett wants to merge 1 commit into
Open
fredrivett wants to merge 1 commit into
fredrivett wants to merge 1 commit into
Conversation
The loading skeleton renders its own Radix Dialog but, unlike the real dialog, didn't suppress Radix's default zoom/fade or the backdrop fade. Since the skeleton only ever appears mid-swap (its seed comes from a similar-images click), that made the swap flash through the loading frame. Suppress those animations to match the real dialog so it pops in instantly; the resolved dialog that follows is already instant (animateEntrance=false on a swap). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #491. That killed the flash when swapping between loaded items, but a transition remained on the skeleton path — when the swapped-to item isn't loaded yet and the seed skeleton shows first.
The loading
ItemDialogSkeletonrenders its own RadixDialog, but unlike the real detail dialog it didn't suppress Radix's default enter animation (zoom-in-95 fade-in-0) or the backdrop fade. Since the skeleton only ever appears mid-swap (its seed comes from a similar-images click, which is always a swap), that made the swap zoom/fade through the loading frame.Suppress those animations on the skeleton's
DialogContent(and overlay) to match the real dialog, so it pops in instantly. The resolved dialog that follows is already instant (animateEntrance=falseon a swap, from #491), so the wholedialog → skeleton → dialogpath is now seamless.Checklist
captureServerException/ the error boundary, or N/ANotes
Please confirm on deploy.
Summary by cubic
Removes the skeleton dialog's entrance transition on swaps so the swap no longer flashes through the loading frame.
The skeleton renders its own Radix
Dialogbut didn't suppress the default zoom/fade or backdrop fade, unlike the real detail dialog. This suppresses those animations on the skeleton'sDialogContentand overlay, so it pops in instantly. Since the resolved dialog was already instant on swaps (#491), the wholedialog → skeleton → dialogpath is now seamless. Please confirm on deploy.Written for commit 276b278. Summary will update on new commits.