Skip to content

Make File observations the sole file-matching source #58

Closed

Description

@frap129

Parent

#38

What to build

Make normalized File observations from successful supported operations the exclusive source for glob and content matching, removing incidental paths from prose and unsupported tools from the file-matching trust boundary.

Acceptance criteria

  • Glob-only and content-scoped Rules obtain file context exclusively from successful Read, Write, Edit, Apply Patch, and path-associated LSP observations.
  • Grep, Glob, shell, custom and MCP tools contribute neither paths nor content, whether successful or failed.
  • User and assistant prose, attachments, metadata, diagnostics, and incidental path-like text cannot select file-scoped Rules.
  • Existing condition families retain their current algebra, lifetime, identity, framing, and delivery semantics.
  • Legacy path extraction is removed from production matching and compatibility tests are updated to assert the intentional trust-boundary change.
  • No proactive, hidden, startup, or historical filesystem scan is introduced.

Blocked by

Activity

  1. frap129 commented on Aug 30, 2026

    @frap129
    OwnerAuthor

    Implemented in 1d4504d.

    • Glob-only and content-scoped rules obtain file context exclusively from successful Read, Write, Edit, Apply Patch, and path-associated LSP observations: FileObservationContext is the only matching input (src/runtime.ts:411, populated solely by live tool.execute.after events)
    • Grep, Glob, shell, custom/MCP tools contribute neither paths nor content: src/index.runtime.test.ts:801 ('supported file tools produce observations; excluded tools do not')
    • Prose, attachments, metadata, diagnostics, and incidental path-like text cannot select file-scoped rules: src/index.integration.test.ts:77,144 assert historical tool parts and supplied messages never select file-scoped rules
    • Condition-family algebra, lifetime, identity, framing, and delivery semantics unchanged: src/rule-filter.test.ts, src/rule-delivery.test.ts retain full coverage
    • Legacy path extraction removed from production matching (FileObservationContext.recordMessageParts and SessionWorkingContextOptions.onObservations deleted); message-paths.ts survives only as the documented compatibility facade; tests updated to assert the intentional trust-boundary change
    • No proactive, hidden, startup, or historical filesystem scan introduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions