Repository navigation
Conversation
Each occurrence also records the message it was raised with in its context, since a grouped error keeps only the first one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116.
Adds
config.solid_errors.fingerprint, a proc called with the exception and its stored attributes (exception_class,message,severity,source). Occurrences whose procs return the same string are grouped into one error. The subscriber still hashes the result, so thefingerprintcolumn keeps its format.SHA256(values.join).req_id, plus a third that differs otherwise. The first two become one error with two occurrences, and the third stays a separate error.message, unless the app already set that key. Its id stays findable, and it shows with the occurrence's other context on the error page and in the email. The copy goes through the sanitizer like everything else in the context, so the existing 64 KB string cap applies to it. This adds a key to every occurrence's context, not only grouped ones. One existing test that asserts a whole context hash gains it.ignored_errorsand a short "Grouping occurrences into errors" section, and "What each occurrence records" now mentions the message.I left
CHANGELOG.mdalone, since the entries link to the PR. I'm happy to add the line once this has a number.