Repository navigation
docs: fix claims that do not match the code, add Meso-NH to the README - #275
Merged
Merged
Conversation
…EADME computeSpeed example that never finds the model, plot with a model name, ignored FireFront options, perimeterResolution, frontCurvature, maxSpeed, bmapLayer, fuelsTableFile path, SWLngLat precedence, unused cooling and Balbi2020.Cpa / WindDriven windReductionFactor, JOSS reference, wind direction and array shape in the Python examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked the Sphinx guide against the code and fixed what did not match (broken
computeSpeedexample,plotwith a model name, ignored options, wrong defaults, JOSS reference). Parameters the code reads but never uses are dropped from the docs; the code side is in a separate PR. README gets a short Meso-NH section pointing totests/mnh_coupled.bash.Part of #263, #266.