Repository navigation
fix(core): a domain built without loadData takes its propagation model from the parameters - #243
Merged
Merged
Conversation
…l from the parameters FireDomain[...] alone left no propagation layer, so the first goTo dereferenced a null one. The layer is now created on first use from the propagationModel parameter, as loadData does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should a bare
FireDomain[...]spread with thepropagationModelparameter, asloadDatadoes? This PR assumes yes.Today, a domain built without
loadDataand withoutaddLayer("propagation", ...)has no propagation layer. The firstgoTothen segfaults inFireDomain::getPropagationSpeed, which dereferences a nullpropagativeLayer. Repro:Fix:
getPropagationSpeednow creates the missing layer on first use frompropagationModel(defaultIso), which is the ruleloadDatafollows. If that model doesn't exist, it prints the samePROBLEMline asloadDataand the fire doesn't spread.Tests: 1 new unit case, which segfaults on
dev. Unit 52/52, ctest 12/12.Drafted with Claude Opus 5.5.