Skip to content

Unexpected values in getSpeed method of Balbi2020.cpp #99

Closed as not planned

Description

@gmarujo

Dear ForeFire Authors and Contributors,

I apologize for returning to this matter, but the truth is that I still haven't been able to successfully run a simulation using the Balbi2020 model.

To assist with the debugging process, I asked Gemini to add print statements throughout the src/propagation/Balbi2020.cpp file. This allowed me to observe that the variable values within the getSpeed method do not match those specified in the .csv file (I have been using tests/runff/fuels.csv in my examples). For instance, the variable Ti, which I believe represents the ignition temperature, appeared with a value of 70000. However, this value is assigned to a different variable in the .csv file (Tau0, if I'm not mistaken).

Due to this apparent mismatch in variable assignments, parameters such as the mean flame temperature and the rate of spread were calculated as negative, which in turn triggered the error I had previously reported.

Later, purely for debugging purposes, I assigned sequential values to the variables (e.g., Rhod=1, Rhol=2, Md=3, etc.). The results of this test can be found in the attached file.

I also analyzed the code in src/propagation/Balbi2020.cpp in more detail and compared it to src/propagation/Rothermel.cpp, but I was unable to identify any clear cause for this issue.

I should mention that I am not a programmer (my background is in Physics) and I am not particularly experienced with C++. Is there perhaps a detail I’m overlooking? What would you suggest as a path forward to resolve this apparent bug?

Thank you in advance for your attention. I'll be happy to provide additional information if needed.

Best regards,
Gonçalo Marujo
Integrated Master in Physics Engineering
Nova School of Science and Technology

Balbi2020_Debug.xlsx

Activity

  1. filippi commented on Aug 11, 2025

    @filippi
    Contributor

    Hi,

    Sorry for late answers,
    more details of the ROS models can be found here :
    https://github.com/forefireAPI/wildfire_ROS_models
    Eventually this will be used to generate the ROS cpp models... unsure how to do that nicely at the moment.

    in fact, it is likely Balbi would have different parameters, it is up to the user to test which one they want. There are a very wide range of parameters for fuel, nothing really fully standards (even in the Andrews/Rotehrmel world) it were much depends on which publication is referred.
    Sotty about that, definitely need more community help to make test cases for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions