Repository navigation
feat(spm): Package.swift for package_info_plus_tvos - #31
Merged
Merged
Conversation
The June SwiftPM pass covered the Swift method-channel plugins. This one was left on CocoaPods because it is Objective-C. One Objective-C target over the unchanged Classes/, public headers in include/package_info_plus. Split out of #27 as the reviewer asked. Patch bump to 0.0.2 with a CHANGELOG entry and a README note. No API change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pixette
marked this pull request as draft
November 9, 2026 07:09
…r SwiftPM With tvos/Package.swift, flutter-tvos links the plugin through SwiftPM, and the example's old Runner.xcodeproj had no reference to the generated FlutterGeneratedPluginSwiftPackage, so the example failed to build. The project now follows url_launcher_tvos's example: package reference, Podfile that skips plugins with a Package.swift, no MetalLibInterposer. AppDelegate and Info.plist take flutter-tvos's UIScene migration. Deployment target 15.0, since Xcode 27 rejects 13.0 for the simulator. Bundle id and display name unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pixette
marked this pull request as ready for review
November 9, 2026 07:20
10 of 11 tasks
MAUstaoglu
approved these changes
Nov 9, 2026
MAUstaoglu
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for splitting it out. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
tvos/Package.swifttopackage_info_plus_tvos, so flutter-tvos links it through Swift Package Manager instead of CocoaPods. The June SwiftPM pass covered the Swift method-channel plugins. This one was left out because it is Objective-C.One Objective-C target over the unchanged
Classes/, public headers ininclude/package_info_plus. Sources, Dart code and the podspec are unchanged apart from the version bump.Split out of #27 as suggested in the review there. The Firebase ports stay in #27 and move to SwiftPM together.
Package(s) touched: package_info_plus_tvos
How was it tested?
example/appdart analyzeis clean for the package (no Dart changes)Builds, all with flutter-tvos on Xcode 27:
example/app: simulator debug and release. It runs and shows the real app name, bundle ID, version 1.2.3, build 4 and install times.package_info_plus+ this package: simulator debug, release and profile, and device release with--no-codesign.path_provider_tvosandshared_preferences_tvos(both already on SwiftPM): simulator debug and release, all three plugins working.FlutterGeneratedPluginSwiftPackagelinkspackage-info-plus-tvos, and no pod is installed for it.I also use this exact
Package.swiftin a production app (Pixette, a photo slideshow).check_repo.py .and--selftestpass.Example app: its old
Runner.xcodeprojhad no reference toFlutterGeneratedPluginSwiftPackage, so the example failed once the plugin shipped aPackage.swift. I regenerated it afterurl_launcher_tvos/example: package reference, a Podfile that skips plugins with aPackage.swift, and noMetalLibInterposer. The deployment target is now 15.0, because Xcode 27 rejects 13.0 for the simulator. Bundle ID and display name are unchanged. The other examples still on 13.0 (for exampleurl_launcher_tvos,path_provider_tvos,shared_preferences_tvos) will hit the same deployment-target error on Xcode 27. I left them alone to keep this PR to one package.Versioning & changelog
version:inpubspec.yaml: 0.0.1 → 0.0.2, with the podspec'ss.versionto match.CHANGELOG.md, under a heading identical to the new version0.x: patch, as in the June SwiftPM passChecklist
TODO/debug leftovers in the diff🤖 Generated with Claude Code