Skip to content

Support Flutter Web - #197

Merged
frank06 merged 2 commits into
flutterdata:masterfrom
ariejan:185-flutter-web
Jan 21, 2023
Merged

frank06 merged 2 commits into
flutterdata:masterfrom
ariejan:185-flutter-web

Conversation

@ariejan

@ariejan ariejan commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

This is still a work in progress, creating this PR now to see how Github Actions will respond.

@frank06

frank06 commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Appreciate the PR, before any merge I'd like to make sure we have ongoing web support: #185

@ariejan

ariejan commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

@frank06 that was the point of the PR ;-)

  1. Could you, @frank06 approve this PR for Github Actions? So, not an approval of the PR, but just to run github actions.
  2. Right now web tests are run with -p chrome which seems to fail. Running -p firefox shows green tests. Right now I think there's something wrong with running tests and/or mockito on chrome (not "web" as a whole).

Once Github Actions is active, I can test my changes more thoroughly.

@ariejan

ariejan commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

Looking further into failing tests for web, they all share one thing: await oneMs() from setup.dart. The goal is to let things settle before making assertions, however, on slower systems when running in-browser tests this is not enough time.

I bumped the duration in oneMs to 10ms and that makes all tests pass without issue.

@ariejan ariejan changed the title [WIP] Support Flutter Web Support Flutter Web Jan 5, 2023
@frank06

frank06 commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Makes sense, thank you! I have encountered other issues on web in the past that were not related to timing, and these were very difficult to debug. Hopefully things get better

@frank06
frank06 merged commit 7fb2917 into flutterdata:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants