Repository navigation
Support Flutter Web - #197
Merged
Merged
Conversation
Contributor
|
Appreciate the PR, before any merge I'd like to make sure we have ongoing web support: #185 |
Contributor
Author
|
@frank06 that was the point of the PR ;-)
Once Github Actions is active, I can test my changes more thoroughly. |
Contributor
Author
|
Looking further into failing tests for web, they all share one thing: I bumped the duration in |
Contributor
|
Makes sense, thank you! I have encountered other issues on web in the past that were not related to timing, and these were very difficult to debug. Hopefully things get better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, creating this PR now to see how Github Actions will respond.