Repository navigation
[material_ui] Batch release - #12953
Closed
fluttergithubbot wants to merge 1 commit into
Closed
fluttergithubbot wants to merge 1 commit into
fluttergithubbot wants to merge 1 commit into
Conversation
fluttergithubbot
added
the
override: batch-material_ui
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request bumps the version of the material_ui package to 1.4.0, updates the changelog with new features and bug fixes, and removes individual changelog fragment files. Feedback on the pull request suggests updating a changelog entry from 'Fix' to 'Fixes' to maintain grammatical consistency with other entries.
| ## 1.4.0 | ||
|
|
||
| - Adds sortIconBuilder parameter to DataTable, PaginatedDataTable, and DataTableThemeData for custom sorting indicators. | ||
| - Fix `PopupMenuButton` not announcing button semantics (enabled state, expanded state) when built with a `child` instead of the default icon. |
Contributor
There was a problem hiding this comment.
For consistency with the other changelog entries (e.g., 'Adds', 'Fixes'), please use the third-person singular form 'Fixes' instead of 'Fix'.
Suggested change
| - Fix `PopupMenuButton` not announcing button semantics (enabled state, expanded state) when built with a `child` instead of the default icon. | |
| - Fixes `PopupMenuButton` not announcing button semantics (enabled state, expanded state) when built with a `child` instead of the default icon. |
Contributor
|
This should not be released, as it would be another release subject to flutter/flutter#192839 |
Contributor
|
Closing and deleting this release branch. We'll re-trigger release manually after #12944 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created automatically to batch release the
material_ui.