[pq]

Ensures that when DASH__SUPPRESS_ANALYTICS is set to true it will be propagated to subtools.

The issue is that ErrorHandlingProcessManager always set DASH__SUPPRESS_ANALYTICS to !telemetryEnabled. That overwrote a true inherited from a parent tool, so sub-tools (e.g. DAS) could report during the root tool's first run.

A true from the parent environment or from the caller is now always kept. Otherwise behavior is unchanged: an inherited false does not override this tool's own disabled telemetry, so suppression can only be added down the chain, never removed.

Follow-up to #186780.

(Fixes flutter/dash-devexp-internal#99.)

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant in-code documentation (doc comments with ///).
• If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in flutter/website (or verified none is needed).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[gemini-code-assist]

Code Review

This pull request modifies ErrorHandlingProcessManager to propagate the DASH__SUPPRESS_ANALYTICS environment variable. The manager now checks if suppression is requested as 'true' in either the platform environment or the caller-supplied environment, and propagates 'true' if so; otherwise, it sets the variable based on the telemetry status. Unit tests in process_test.dart are refactored with a new helper method and expanded to cover various scenarios of analytics suppression propagation. No review comments were provided, and there is no additional feedback.

[bkonyi]

LGTM!