Skip to content

Scenarios: Fix multiple-clips scenario doc comments - #190830

Merged
cbracken merged 1 commit into
flutter:masterfrom
cbracken:fix-multiple-clips-doc-comments
Aug 11, 2026
Merged

cbracken merged 1 commit into
flutter:masterfrom
cbracken:fix-multiple-clips-doc-comments

Conversation

@cbracken

Copy link
Copy Markdown
Member

The ...MultipleClipsScenario constructors each copy their doc comment from the corresponding single-clip scenario, so none of them mention the extra clip that distinguishes them.

Updates each to say it constructs the multiple-clips variant.

Spotted by Gemini review bot during review of #190826.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

The `...MultipleClipsScenario` constructors each copy their doc comment
from the corresponding single-clip scenario, so none of them mention the
extra clip that distinguishes them.

Updates each to say it constructs the multiple-clips variant.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 10, 2026
@cbracken
cbracken requested a review from hellohuanlin August 10, 2026 06:38
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Aug 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the constructor documentation comments for several platform view scenario classes in platform_view.dart to accurately reflect their specific scenario types, such as incorporating 'and multiple clips' or 'after moved' into the descriptions. There are no review comments, and I have no feedback to provide.

@hellohuanlin hellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im probably guilty of a few of these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants