Repository navigation
馃 chore: sync skills directory from dart-lang/skills - #248
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the plugin version to 1.0.7 across configuration files and refines the Dart pattern matching skill guide (SKILL.md) with detailed guidelines on when to use object destructuring versus standard property access. The review feedback suggests clarifying a bullet point in the guide to explicitly distinguish between reading a single property and avoiding deeply nested object patterns.
| Use standard property access (`user.name`) rather than object pattern destructuring (`final User(:name) = user;`) when reading a single property on a known non-null instance. | ||
| ### 5. Use Object Destructuring for Multi-Field Unpacking, Not Single Properties or Passthroughs | ||
| Use object or record destructuring when extracting 3+ fields used across multiple statements, iterating `MapEntry(:key, :value)` in `map.entries` loops, eliminating a single-use intermediate variable, or promoting nullable fields to local variables (`:field!` or `:field` with `!= null`). Keep standard property/element access (`config.field`) when: | ||
| * Reading a single property (`user.name`, or `final CpuCallFrame(:url, :line) = node.callFrame;` rather than nesting `ProfileNode(callFrame: ...)`). |
There was a problem hiding this comment.
The bullet point description mentions "Reading a single property", but the second example (final CpuCallFrame(:url, :line) = node.callFrame;) actually extracts two properties and is intended to demonstrate avoiding nested object patterns (i.e., avoiding nesting ProfileNode(callFrame: ...)).\n\nTo prevent confusion, it would be clearer to explicitly separate these two distinct cases (reading a single property vs. avoiding nested object patterns).
| * Reading a single property (`user.name`, or `final CpuCallFrame(:url, :line) = node.callFrame;` rather than nesting `ProfileNode(callFrame: ...)`). | |
| * Reading a single property (e.g., `user.name`), or avoiding deeply nested object patterns (e.g., using `final CpuCallFrame(:url, :line) = node.callFrame;` rather than nesting `ProfileNode(callFrame: ...)`). |
27b6947 to
29e0471
Compare
2 participants
Automated changes by create-pull-request GitHub action