Repository navigation
feat(cli): add flock open and flock db - #147
Open
beganovich wants to merge 3 commits into
Open
beganovich wants to merge 3 commits into
beganovich wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
What and why
From discussion #120: Herd's
herd openandherd db. Flock only hadflock worktree open(worktrees only) and no database command.flock open [site|dir]— opens a site in the browser: the current one, by name, or by directory. Uses the URL the daemon serves, or the site's own when the daemon is stopped.flock db [site|dir]— opens the database its.envnames (PostgreSQL, MySQL, MariaDB, SQLite, MongoDB) in the client registered forpostgres:///mysql://links, else an installed TablePlus, TablePro, DataGrip or DBeaver.--urlprints driver, host, database, user and URL instead.How I tested it
Both commands against a throwaway
FLOCK_HOME:openby directory,db --urlfor PostgreSQL and SQLite,--clientwith and without%s, and the error paths (unknown site, no.env, unknown driver). Unit tests cover the driver URLs, masking, the client splitter and site/directory resolution.go test -race,go vet,gofmtand builds for linux/darwin/windows are clean.Not tested on macOS or Windows.