Skip to content

refactor: move manual sync recovery into submission - #91

Merged
flexdinesh merged 1 commit into
boundaries/state-dirfrom
boundaries/submission-sync
Oct 22, 2026
Merged

flexdinesh merged 1 commit into
boundaries/state-dirfrom
boundaries/submission-sync

Conversation

@flexdinesh

@flexdinesh flexdinesh commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner
  • Behavior owner and resulting change: submission owns manual sync recovery. submission.Sync holds the outbox loop moved verbatim from cmd/diffx/sync.go; the command only collects, calls and prints. Hooks and outbox share submission.AcknowledgementTTL. Hooks keep job/session-scoped state; docs say why.
  • Contracts/invariants affected; local/remote implications: see above; both modes covered by existing boundary tests.
  • Validation results; remaining risks: Existing sync suite passes unchanged. Pre-push check:push passed on push; mise run check passed on top of stack. Every layer: frozen install, Go build/vet/test, boundaries, static checks, contracts.
  • Intentional architecture/design changes and rationale (if any): Transport/command stays thin; service owns rules.
  • UI evidence: n/a

@flexdinesh
flexdinesh added this pull request to stack #99 October 22, 2026 16:01
- submission.Sync owns route outbox recovery; cmd/diffx only collects and prints
- hooks and outbox share submission.AcknowledgementTTL
- docs state why hooks keep job/session-scoped state
@flexdinesh
flexdinesh force-pushed the boundaries/submission-sync branch from 55860d8 to b00a3ab Compare October 22, 2026 23:12
@flexdinesh
flexdinesh marked this pull request as ready for review October 22, 2026 23:12
@flexdinesh
flexdinesh merged commit fbdb944 into main Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant