Skip to content

feat: simplify review navigation; capture-only shell policy - #112

Merged
flexdinesh merged 1 commit into
mainfrom
feat/review-nav-simplify
Oct 25, 2026
Merged

flexdinesh merged 1 commit into
mainfrom
feat/review-nav-simplify

Conversation

@flexdinesh

Copy link
Copy Markdown
Owner
  • Remove stream inbox (StreamInbox.tsx, inbox state in use-stream-nav.ts, filter helpers in project-nav.ts, CSS) and header "N new" button: four overlapping ways to switch reviews collapse to three (Reviews column, header comboboxes, header search). Unread marks on rail/list remain the arrival signal.
  • Search moves from the Reviews column to the header (SearchReviewsButton, Cmd/Ctrl+K) and opens the existing picker.
  • Repo rail mark and list repo name open the repo's most active stream (latestStream); the chevron alone toggles. New components/disclosure-row.tsx primitive holds the two-target row. Closed-group state now saves synchronously, since opening a stream remounts the column and dropped the save effect.
  • Header repo/branch switchers become filterable comboboxes on new components/ui/combobox.tsx (Base UI combobox, menu tokens shared via menuPopupClassName/menuItemClassName). Branch filter (streamMatches) searches branch, worktree, host and sessions. Gallery page and goldens added.
  • Local Bootstrap gains required input: checkouts | capture (OpenAPI, generated client, readBootstrap, Capabilities.Input()). Web shell-policy.ts derives reviewNavigation; a capture (piped stdin, dev --fixture) shows only its diff and file sidebar: no column, search, Cmd+K, picker, comboboxes or sync.
  • Piped-specific picker/nav branches removed; stray stdin contexts in checkout or remote mode render like any review.
  • Tests: shell geometry tests route bootstrap to checkouts (withReviewNavigation); new pipe-mode test; local-workspace specs rewritten for new behaviors. Docs updated (DESIGN.md, docs/system.md, docs/development.md, PRODUCT.md, docs-website).

Validation: mise run check passes (76 unit, Go, 117 Playwright incl. gallery).

- Remove stream inbox and header "N new" button
- Header search opens review picker (Cmd/Ctrl+K)
- Repo rail mark and list name open latest stream; chevron toggles
- Header repo/branch switchers are filterable comboboxes (new ui/combobox primitive)
- Bootstrap declares local input (checkouts|capture); capture shows one diff, no navigation
- Drop piped-specific UI outside capture mode
@flexdinesh
flexdinesh merged commit faf9f0d into main Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant