Skip to content

fix(web): muted comparison picker border; 28px status bars - #108

Merged
flexdinesh merged 1 commit into
mainfrom
ui-toolbar-polish
Oct 24, 2026
Merged

flexdinesh merged 1 commit into
mainfrom
ui-toolbar-polish

Conversation

@flexdinesh

Copy link
Copy Markdown
Owner
  • Comparison picker (Branch changes ▾): outline → outline-muted. It used the 3:1 --border-control border while its neighbors (Reviewed, Reset reviewed, segmented controls, file filter) use --border-muted, so it looked heavier than the rest of the toolbar.
  • Status bars: --statusbar-height is now --control-compact + --space-1 (28px, border included), down from 33.8px. DESIGN.md already gave 28px but the token was derived from text height and padding. The sidebar footer drops its vertical padding so it matches the token. The review, sidebar, inbox and loading footers all share the token, so they stay the same height.
  • DESIGN.md: notes the picker variant and how the status bar height is derived.

Validation

  • mise run check: pass (browser suite 114 passed, including gallery goldens; design guard passed)
  • Impeccable detector: no findings
  • Checked in the browser at 1400px (light and dark) and 390px: both footers 28px, footer buttons unclipped, picker border matches Reviewed

@flexdinesh
flexdinesh marked this pull request as ready for review October 24, 2026 01:40
@flexdinesh
flexdinesh merged commit 9c37137 into main Oct 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant