Repository navigation
Conversation
satwiksps
force-pushed
the
containerd-dropin-config
branch
from
August 6, 2026 01:27
1e044ba to
a5b3566
Compare
satwiksps
force-pushed
the
containerd-dropin-config
branch
from
September 13, 2026 13:42
a5b3566 to
a2b71f9
Compare
3 tasks
tormath1
reviewed
Oct 9, 2026
tormath1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this PR and sorry for the delay here. :) It looks good, let's take this opportunity to upgrade containerd config. To avoid warnings like that:
Oct 09 07:33:33 localhost containerd[1437]: time="2026-10-09T07:33:33Z" level=warning msg="Ignoring unknown key in TOML" column=1 error="strict mode: fields in the document are missing in the target struct" file=/usr/share/containerd/flatcar-config.toml key=subreaper row=3
| @@ -1,5 +1,8 @@ | |||
| version = 2 | |||
Contributor
There was a problem hiding this comment.
While here, can we bump the version 2 to version 3 ? Like so folks can drop containerd configuration to version 2 or 3. It's not possible to do the other way (i.e drop-in version 3 with a base configuration using version 2).
This might:
- drop
subreaper - drop the
[plugins."io.containerd.runtime.v1.linux"]plugin - rename the
io.containerd.grpc.v1.criplugin - we can drop the
grpcsection as well, it's the same as the default config
| @@ -1,5 +1,8 @@ | |||
| version = 2 | |||
Custom containerd settings currently require a copy of the shipped configuration, which misses later changes to its defaults. Import /etc/containerd/conf.d/*.toml from both shipped configurations and use version 3 so local settings can use version 2 or 3 drop-ins. Move CRI settings to the runtime plugin and remove obsolete settings and redundant gRPC defaults. Signed-off-by: Satwik Sai Prakash Sahoo <sahoospsatwik@gmail.com>
satwiksps
force-pushed
the
containerd-dropin-config
branch
from
October 11, 2026 17:29
a2b71f9 to
554d8d1
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing containerd settings currently requires copying the shipped config, which can miss later updates. This adds
/etc/containerd/conf.d/*.tomlimports to both configs so users can keep their settings in separate files.Both configs now use version 3 to support v2 and v3 drop-ins. This also removes obsolete settings, updates the CRI plugin names, and drops the redundant gRPC section.
How to use
Create
/etc/containerd/conf.d/50-log.toml, then restart containerd:Testing done
Tested both configs with containerd 2.3.5 in isolated WSL mount namespaces. Local validation scripts reported:
Covered v2/v3 imports, ordering, preserved defaults, missing/empty directories, invalid config and recovery.
git diff --checkpassed with no output.The updated configs have not been tested in a Flatcar VM.
AI assisted with code changes and local tests under my supervision.