Repository navigation
Conversation
Map diagram endpoints explicitly and wait for layout stabilization so arrows render against final coordinates and remain correctly positioned in print output
Ensure @LiVe templates render through the browser path automatically and raw MDX is transformed before React in dev mode. Prevents incorrect static rendering and React parse failures.
Add doctor coverage for the shared Facet module store and Tailwind package/plugin layout. This surfaces missing or incompatible dependencies and supports repair through `facet doctor --skip-modules --fix`.
Add immutable shared module stores, persistent build-key digests, Tailwind v3/v4 CSS handling, filtered Markdown transforms, and low-priority subprocess execution to reduce repeated install, scan, and render costs. Add skip-modules support and improve cache invalidation, diagnostics, and loader cleanup. BREAKING CHANGE: Replace the positional computeTemplateBuildKey API and remove FacetDirectory.needsInstall and isInstallBroken; callers must use the new options-based and module-preparation APIs.
Add Facet server rendering for HTML/PDF jobs while preserving local data loading and validation, with explicit failures instead of local fallback. Introduce version-pinned shared modules, CSS post-processing controls, render timing diagnostics, and expanded API coverage for live/PDF options. BREAKING CHANGE: Require Node.js >=20.19; shared-module server mode rejects request-specific dependencies and local-only render options.
Make browser-backed diagrams render consistently in HTML/PDF output and expand the playground with reusable datasheet, diagram, Markdown, and MDX examples. Keep shared playground links reproducible through URL-synced toolbar state and surface server timings in the log dialog.
Deprioritize shell, SSR, and PDF browser work to reduce contention with interactive workloads. Extend benchmark profiling across stdout and stderr, and support numeric logger verbosity levels.\n\nBREAKING CHANGE: PersistentLoaderRequest replaces the verbose option with verbosity
Build and install the CLI from a versioned npm package with symlinked development installs and linked-version reporting. Add shared module-cache warmup, bundled runtime assets, and repeatable Kubernetes lab deployment with optional ingress.\nBREAKING CHANGE: The npm CLI now requires Node.js >=20.19 instead of >=18.
Expand the kitchen-sink report to exercise GFM, raw HTML, GitHub alerts, collapsible details, footnotes, and Mermaid diagrams. Add the rendering dependencies and remote HTML/PDF CLI integration coverage.
Replace react-xarrows rendering with measured SVG geometry so arrows stay aligned as diagram layouts settle. Preserve anchors, paths, markers, labels, and animation while adding layout readiness and geometry regression coverage.
Add PNG output with configurable capture dimensions, selectors, viewports, and autocropping. Extend request validation, caching, streamed results, and playground previews for image renders.
Add PNG generation across the CLI, render API, and remote rendering path. Capture selected elements at natural size with viewport-aware scaling and optional painted-pixel autocropping. Bundle Sharp resolution for native module environments, document the new format, and cover local, API, remote, and cropping behavior with tests.
Centralize data-file loading with YAML support and clear validation errors. Select the appropriate JSON Schema draft while preserving renderer annotations without weakening actual constraints.
Bundle icon data and load template utilities so live and SSR renders preserve glyphs and diagram layout. Resolve the Vite root reliably and include sharp for SEA autocrop support. Add React 19 diagram coverage for finite arrow geometry.
Promote Document as the canonical wrapper across examples, playground templates, and Storybook while retaining DatasheetTemplate as a deprecated compatibility alias.
Add a validated font-size scale that keeps typography consistent across HTML, PNG, and PDF output. Align Tailwind utilities, inline styles, and packaged PostCSS processing with the shared point-based scale while preventing stale CSS caches and unsafe stylesheet interpolation. Add component test discovery and coverage for scaling, packaging, rendering, and cache invalidation.
Correct PDF output that ignored the declared typography scale, overflowed page boxes, and misreported debug annotations. Apply consistent font scaling and printable-height sizing across page surfaces, load the intended sans font, and prevent oversized page-number replacements from corrupting streams. Add focused coverage for rendered typography, scaling, pagination, annotations, and placeholder safety.
Synchronize public facet declarations with current component exports, including document, table, finding, formatting, heatmap, and typography APIs. Align StatCard tests with absolute deltas, slate neutral colors, and reduction semantics. BREAKING CHANGE: Remove legacy DatasheetTemplate PageConfig usage and the TerminalOutput command and SeverityStatCard downIsGood props from the declared API.
Unify TSX/MDX callouts with GitHub markdown alert tones, shared icons, annotation headers, and emphasis styling. Add focused component coverage and Storybook examples for the expanded API. BREAKING CHANGE: Remove the `info` and `success` variants; use `note` and `tip` instead
Add GitHub-style alert rendering and fail-closed Classified regions across Markdown/MDX, CLI, API, and cached builds. Redacted content is removed before compilation and remote-render policies are preserved. Document and test callout tones, policy parsing, CSS, and rendering behavior. BREAKING CHANGE: CalloutBox no longer accepts the info or success variants; use note, tip, important, warning, caution, or default
Read workspace-level pnpm overrides and explicitly disable frozen-lockfile mode during staging installs to keep generated consumer manifests and pnpm 11 resolution consistent. Remove obsolete dependency checksums from the chart test module.
Remove classified Markdown regions before compilation so redacted content is absent from generated bundles and output. Enforce explicit attribute policies and fail builds when classification rules are missing or malformed.
Restore correct block-level heading flow and style GitHub Markdown alert tones consistently with CalloutBox variants, including readable labels and icons.
Keep release, test, and runtime environments consistent with the repository’s pnpm requirement while covering packaged remark assets, layered CSS imports, and sharp diagnostics.
…outBox and FlowDiagram
…uild Mark 'marked' and the 'dayjs/' subpath pattern as rollup externals so the Facet library no longer bundles its own copies. Bundling them duplicated these dependencies in every consumer install and could break Day.js plugin resolution. Consumers must now provide 'marked' and 'dayjs' as dependencies. BREAKING CHANGE: the library no longer bundles 'marked'; consumers must install it alongside the package. Adds a vitest case that asserts these externals stay configured, so future config edits do not silently re-bundle them.
|
Important Review skippedToo many files! This PR contains 417 files, which is 317 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
|
Chromium only emits named destinations for links referenced within the same printed group, so links to other groups were lost in multi-pass output. Probe anchors register each target in its owning Page, and links are rewritten to a placeholder URI that is converted to GoTo actions after assembly. Automatic TOC entries now resolve to their actual printed page, and encoded destination names are used when looking them up. Missing or duplicate link targets inside a Page now fail PDF generation instead of producing dead links. Refs #internal-links
Adds `facet docx` and `facet pptx` commands and matching generateDOCX/generatePPTX library exports so templates can produce editable Office files without Word, PowerPoint, or LibreOffice. Rendering runs in headless Chromium, which reads the laid-out DOM into a semantic model. Paragraphs, lists, tables, links, and native page fields (PAGE/NUMPAGES) stay editable. Table padding, borders, merged cells, and fixed widths are preserved. TableOfContents becomes a native Word TOC with bookmarks and PAGEREF fields. Headers, footers, and figures or diagrams that cannot be expressed natively in Word are embedded as single-page PDF OLE objects with no raster preview, so display depends on the viewer's PDF embedding support. PowerPoint embeds complex visuals as PNG images, paginates to 16:9 slides, and repeats table headers across continuation slides. Export fails instead of silently dropping unsupported content such as form inputs, missing or duplicate TOC targets, and column groups that cannot fit on a slide.
Claude-Session-Id: 01a15a84-7bc0-7ed2-9b60-a832850ca330
Claude-Session-Id: 01a15a84-7bc0-7ed2-9b60-a832850ca330
Move CI workflows, tsdown targets, and package engines from Node 20/22 to 24. Add puppeteer-core 22.15.0 and inline dependencies in the tsdown bundle so the CLI build is self-contained. Point the types entry at dist/index.d.mts and expose the CLI via a ./cli export. BREAKING CHANGE: Node.js 20 and 22 are no longer supported; installs now require node >=24.
…playground export Resolve internal PowerPoint links to destination slides after pagination, and support per-side table borders, cell padding, and header/footer decorations. The playground can now export DOCX and PPTX with an HTML source preview. Loader dispatch moves into dispatchLoader(), shared by the CLI and index entry points. Unknown FACET_LOADER values now throw. Vite resolves @flanksource/facet via import.meta.resolve instead of a hardcoded node_modules path. Tailwind v3 post-process builds use per-render config and CSS files so concurrent renders do not collide. TAILWIND_CACHE_VERSION invalidates stale CSS caches.
…G files Adds docx-to-pdf.sh, which drives Microsoft Word through AppleScript and a Swift helper to capture each page of a DOCX as input.docx.N.png beside the source. Capturing from Word's own layout avoids a separate converter, so pages render as Word displays them. Moves runtime asset copying out of pack-npm-cli.cjs into copy-runtime-assets.cjs so the npm packaging step and other callers share one asset manifest. Existing captures are never overwritten, and a lock directory serializes Word automation. Page-measurement problems emit warnings rather than failing the run. Requires macOS, Word, and Accessibility, Automation, and Screen Recording permissions.
Claude-Session-Id: 01a161f4-5474-7f11-ba9a-856eee95a830
Claude-Session-Id: 01a161f9-54f8-7e93-9a6e-9806868012da
…xtend layout checks Alternate edges now bend once into the facing target edge instead of splitting halfway, and connectors land on a filled step's body so its badge remains the outgoing port. Lane labels move to FlowLaneLabel.tsx and wrap long names. Layout validation now flags arrow stubs under 12px, arrows ending outside the diagram, text under 8px, and nested boxes that repeat their container's fill and border. BoxNode gains a dashed prop to mark open slots that readers fill with their own content. Header and Footer clamp children to their declared height with overflow hidden. Flow arrowheads grow from 3 to 5 for legibility. The generated /output/ directory is now ignored.
…ffice exports Add prompts/diagram-smells.prompt so rendered PNG, SVG, or HTML diagrams can be linted with `gavel lint prompt`, using stable diagram-smells/<rule> ids. The diagram-designer phase 4 checklist now requires zero diagram-smells errors before delivery. Document the new topology-overview and layered-architecture examples and their wide viewport. Cover facet docx and facet pptx across the CLI, documents, README, and office examples, and raise the required Node version to >=24.
…diagram examples Recreate the topology-overview and architecture SVG references as runnable facet templates, and expand entity-model with relational, junction, event, document, and materialized-view recipes. Add entity-model-types.tsx, a PostgreSQL 18 and SQLite type catalog with shared icon mappings and a legend. The entity-model example imports it, so both files must ship together. Add @flanksource/clicky-ui as a dependency for the icon imports, and register the new templates in the html script. Bump the Dockerfile builder and runtime base images from node:22-bookworm-slim to node:24-bookworm-slim.
Add the logo kit under assets/brand: SVG masters, one-colour and web exports, favicon set, and the README mark. Serve the favicon inline from the playground so facet serve needs no icon route. Wait for the template to mount before snapshotting, so late-mounting diagrams keep their arrows. Serialize project module installs with a lock so concurrent renders do not swap node_modules under each other.
… refs The SSR loader requires exactly one .cjs file and renders synchronously, but lazy imports (such as clicky-ui's code highlighter languages) split the template into chunks, so the loader picked a language chunk and failed with 'Template must export a React component function'. Set inlineDynamicImports so the build emits one bundle, and fail with a clear error when the bundle count is not one. The validator now resolves schema files relative to their location, so nested local $ref chains and boolean schemas validate correctly, and remote $ref targets are rejected explicitly.
Adds BOX_STYLES and CONTAINER_STYLES variant vocabularies, a ContainerNode primitive, and loadBrand/BrandBox so diagrams can be themed from a brand JSON file. BoxNode defaults to the header variant so existing usages render unchanged, but unknown variants now throw.
Diagrams can now expose a data-facet-warning attribute. Warnings are logged during snapshotting but neither count as pending nor fail the render, so non-fatal layout hints no longer need to be reported as errors.
…ocking errors Layout problems used to set data-facet-error and stop the diagram from settling. They now set data-facet-warning, log via console.warn, and still mark the diagram ready, so consumers that relied on the error attribute must switch to the warning attribute. The change also un-ignores the diagram-designer-schema skill and brand HTML assets in .gitignore.
Non-Error values thrown in the page (such as strings) produced an undefined entry because err.stack and err.message are missing, so live render failures lost the exception text. Also awaits puppeteer.defaultArgs, which is now async. BREAKING CHANGE: buildBrowserLaunchOptions now returns Promise<LaunchOptions> instead of LaunchOptions.
…d bump deps Both Dockerfile stages now use the digest-pinned node:24-alpine image, so the standalone binary and native modules share musl libc on amd64 and arm64. Chromium, fonts, ImageMagick and ghostscript come from Alpine packages, replacing the pinned Debian snapshot Chromium and the ImageMagick policy sed workaround. The build also renders HTML and PDF once as a warmup check. The commit bumps puppeteer-core to 25.x, sharp to 0.35.5, js-yaml, vitest, and the Go modules in chart/test. BREAKING CHANGE: the base image moves from Debian bookworm to Alpine, so downstream images or scripts that rely on apt or Debian paths will need updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
markedand thedayjs/subpath pattern as rollup externals in the library build (vite.lib.config.ts)src/components/libraryBuild.test.ts)Why
Notes
marked; consumers must installmarkedanddayjsas dependencies