Repository navigation
chore: release 0.6.1 — scanner-core 0.7.1 - #14
Merged
Merged
Conversation
Picks up @flagrix/scanner-core 0.7.1, which reads a repo's files concurrently
(facebook/react 140.2s -> 16.5s, expressjs/express 58.9s -> 5.9s) and stops
two false positives on legitimate build code: a bundler's own test suite read
as a build script, and `new Function('module', 'exports', 'require', src)`
reported as a critical backdoor. The CLI bundles the engine, so its users had
neither until this release.
A patch, not a minor: both engine fixes only ever remove findings and the
concurrency change is verdict-identical, so no consumer's passing scan starts
failing. Some that were failing on a false positive start passing.
src/cli.ts carried a hardcoded `const VERSION`, which `npm version` does not
reach, so this bump built a CLI that reported 0.6.0. It has been kept in step
by hand through every release so far; tests/version.test.ts now pins it, along
with the two copies in server.json, against package.json. Release CI already
compared the tag with package.json and server.json but never with the literal
the CLI actually prints.
The snapshot being replaced was recorded at engine 0.5.0 on 2026-10-21 — two engine releases back, not one. That is why 0.7.0's false positives on evanw/esbuild and reduxjs/redux went unnoticed for a month: there was nothing current to compare a run against. This run is the full 114 samples at engine 0.7.1 and CLI 0.6.1, all five gates green, engineDirty false — the published artifact from the registry rather than a symlinked checkout, as run.mjs requires of the metadata. 112 of 114 samples pass. The two that do not are reduxjs/redux and puppeteer/puppeteer, where a Docusaurus config's Algolia DocSearch key reads as a hardcoded secret. They are deliberately NOT recorded in reference-review.json as accepted false alarms, because they are not accepted: HARDCODED_API_KEY's precision is an open question for flagrix-detection-rules. Leaving them as a standing warning keeps that visible on every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up
@flagrix/scanner-core0.7.1. The CLI bundles the engine into itsdist, so its users have had neither the speedup nor the false-positive fixesuntil now.
And two false positives on legitimate build code are gone: a bundler's own test
suite read as a build script (which made evanw/esbuild verdict HIGH and
unsafe to clone), and
new Function('module', 'exports', 'require', src)— theCommonJS module wrapper — reported as a critical backdoor.
A patch, not a minor
Both engine fixes only ever remove findings, and the concurrency change is
verdict-identical by construction and by measurement. So no consumer's passing
scan starts failing; some that were failing on a false positive start passing.
That is a bug fix, unlike the exit-code 4 contract change in 0.4.0.
A release bug caught by the smoke test
src/cli.tscarried a hardcodedconst VERSION = "0.6.0", whichnpm versiondoes not reach — so this bump produced a CLI that reported the previous
release:
It has been kept in step by hand through every release so far (checked v0.4.0
through v0.6.0 — all four matched), so the discipline held; this would have been
the first to break it.
release.ymlalready compares the tag againstpackage.json and both
server.jsonversions, but never against the literal theCLI actually prints, and the smoke test only checks that
--versionruns.tests/version.test.tsnow pins all four copies — package.json, the CLIliteral,
server.json .versionandserver.json packages[0].version— so thenext bump cannot drift.
Verified
release.yml'sown comparison logic run locally
node dist/cli.js --versionprints0.6.1--enforce-gatesrun locally — the samerun
release.ymlnow performs before publishingThis is the first release where a red benchmark blocks the publish, so the gate
and the
FLAGRIX_GITHUB_TOKENsecret both get their first real exercise here.Expect one non-fatal line in that step:
2 completed sample(s) missed their expected verdict, from the two Docusaurus false alarms that belong toHARDCODED_API_KEY's precision in flagrix-detection-rules.