Repository navigation
docs: Hold parameter names on controller ROS 2 reference page - #32
Merged
Merged
Conversation
Reference tables for Basic Joint and OCS2 Arm now include hold_first_check_position_threshold and hold_position_threshold with the same semantics as the how-to Hold table, plus links to the shared Hold section for full prose. Updates zh_CN catalog. Co-authored-by: HUANG ZHENBIAO <legubiao@users.noreply.github.com>
legubiao
deleted the
cursor/hold-params-reference-discoverability-0ed0
branch
October 31, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Site search on Controller ROS 2 parameters missed
hold_first_check_position_thresholdandhold_position_thresholdbecause the reference page only linked to the how-to Hold section without spelling those keys in its own tables.Change
StateHold).locale/zh_CN/LC_MESSAGES/4-reference/controllers/8-ros2_parameters.pofor the new strings.Verification
make html/make html-zh_CN— successpython3 scripts/check_zh_coverage.py --threshold 95— 100%python3 scripts/check_zh_mix.py— passbuild/html/4-reference/controllers/8-ros2_parameters.html