Skip to content

Not meaningful timeout default values leading to hanging requests #901

Open

Description

@TheRittler

[REQUIRED] Step 2: Describe your environment

  • Operating System version: MacOS Sonoma 14.1.1
  • Firebase SDK version: v9.2.0
  • Library version: _____
  • Firebase Product: Firebase Cloud Messaging

[REQUIRED] Step 3: Describe the problem

Sometimes the Google Server do not respond (like described in #850 ). However, the default values to read timeout and connect timeout are "0" because they are default initialized with 0 in the FirebaseOptions. So these requests hang for infinite time.

Steps to reproduce:

Send a message via FCM and the SDK. If Google does not respond, there is not timeout.

Fix:

Provide meaningful default values like 20s. This is the default in the Google HTTP Client (com.google.api.client.http.HttpRequest#readTimeout).

Activity

  1. google-oss-bot commented on Jan 10, 2024

    @google-oss-bot

    I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions