HTTP support #17

Activity

1. fhessel commented on Sep 1, 2018

   

   fhessel

   on Sep 1, 2018

   Last edited by fhessel

   Owner

   More actions

   I had this in mind when creating the code, so the whole SSL stuff should mainly be done in the HTTPSServer and HTTPSConnection class – note that many other classes just start with HTTPsomething and should be generic for both protocols. However, parsing the request line and header is not really separated from the SSL connection handling by now, but this can be done by refactoring the HTTPSConnection class so that it does no more than handling the actual SSL stuff and putting everything else in a new class. That would allow to implement an HTTPServer and HTTPConnection that both sit on top of that new class. Creating an instance of HTTPSServer and one of HTTPServer with the same ResourceNodes being configured should then allow you to handle both protocols.
   However, that's not at prio 1 for me, as there are HTTP available for the ESP32 and solving some other issues is more urgent for some personal projects I'm working on at the moment.
2. fhessel

   added

   feature

   on Sep 1, 2018
3. BojanJurca commented on Sep 1, 2018

   

   BojanJurca

   on Sep 1, 2018

   ContributorAuthor

   More actions

   This is exactly what I have done. I introduced additional listening socket in HTTPSServer. Everything else is the same except for minor changes in some functions that read from and write to SSL - they now read directly from and write directly to socket and this is it. All your HTTPS functionalities work under HTTP as well.
4. BojanJurca commented on Sep 1, 2018

   

   BojanJurca

   on Sep 1, 2018

   ContributorAuthor

   More actions

   ... exept for refactoring and new classes. Le me upload the code and then you can decide whether to keep it or not.
5. fhessel commented on Sep 1, 2018

   

   fhessel

   on Sep 1, 2018

   Owner

   More actions

   Thank you for the pull request! I'll have a look at it and see how I can integrate it.
6. fhessel

   closed this as completedin ea6fb5bon Sep 2, 2018
7. fhessel commented on Sep 2, 2018

   

   fhessel

   on Sep 2, 2018

   Owner

   More actions

   I did some refactoring, so now you have an HTTPServer class as well as an HTTPSServer class. You can either use one of them to serve just one protocol or create two instances and run them in parallel (see https_server.cpp for an example).

   My main focus for the refactoring was to have an additional abstraction layer between handling HTTP, so the HTTPS classes now only do the stuff that's specific for TLS. I hope that's also a suitable solution for your project. Thank you again for providing the code!
8. BojanJurca commented on Sep 2, 2018

   

   BojanJurca

   on Sep 2, 2018 via email

   ContributorAuthor

   More actions

   Great work! Thank you. I'll go with your version of course. I just have to make minor changes in my project to adjust to it. V V ned., 2. sep. 2018 ob 03:15 je oseba Frank Hessel < notifications@github.com> napisala:

   …

   I did some refactoring, so now you have an HTTPServer class as well as an HTTPSServer class. You can either use one of them to serve just one protocol or create two instances and run them in parallel (see https_server.cpp for an example). My main focus for the refactoring was to have an additional abstraction layer between handling HTTP, so the HTTP*S* classes now only do the stuff that's specific for TLS. I hope that's also a suitable solution for your project. Thank you again for providing the code! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AouyrRKeA9vqpZgMndD7aQMx3u57JSE1ks5uWzE9gaJpZM4WWPkB> .
9. BojanJurca commented on Sep 2, 2018

   

   BojanJurca

   on Sep 2, 2018 via email

   ContributorAuthor

   More actions

   Frank, I have problems compiling new code with Arduino. Beginning with: HTTPConnection.cpp:449: error: macro "bind" passed 4 arguments, but takes just 3 next = std::function<void()>(std::bind((*itMw), &req, &res, next)); Any idea how to solve this?

   …
10. fhessel commented on Sep 2, 2018

    

    fhessel

    on Sep 2, 2018

    Owner

    More actions

    That line is for a change I made for #10. The bind in that line should be expanded to the bind declared in the functional header of the standard library, but your compiler seems to go for the socket one (which requires exactly three parameters, not one or more). At least that's how I would interpret that error.

    I'll setup a small Arduino project to be able to reproduce it and then try to organize the includes in a non-conflicting way.
11. fhessel commented on Sep 2, 2018

    

    fhessel

    on Sep 2, 2018

    Owner

    More actions

    I can build the project without any problems in the Arduino IDE.

    Could you provide me with some additional info? I think being able to reproduce your problem will make it easier to find its cause, rather than randomly changing some includes and let you try again and again.
    Did you use the latest version of arduino-esp32? Which OS do you use? Which version of the Arduino IDE?

    If you just want to have HTTP/HTTPS in parallel, without the middleware feature, you can work with commit c5d8a1e28c for now.
12. BojanJurca commented on Sep 2, 2018

    

    BojanJurca

    on Sep 2, 2018 via email

    ContributorAuthor

    More actions

    I use Windows 10. I'll install Arduino and ESP tools again from the scratch and try again ... V V ned., 2. sep. 2018 ob 16:09 je oseba Frank Hessel < notifications@github.com> napisala:

    …

    I can build the project without any problems in the Arduino IDE. Could you provide me with some additional info? I think being able to reproduce your problem will make it easier to find its cause, rather than randomly changing some includes and let you try again and again. Did you use the latest version of arduino-esp32 <https://github.com/espressif/arduino-esp32>? Which OS do you use? Which version of the Arduino IDE? If you just want to have HTTP/HTTPS in parallel, without the middleware feature, you can work with commit c5d8a1e <https://github.com/fhessel/esp32_https_server/tree/c5d8a1e28c39ddac6f090c9365bcd48a9879c81a> for now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AouyrRN67LQnM520MVi9-_e06tyPyuMQks5uW-aBgaJpZM4WWPkB> .
13. BojanJurca commented on Sep 2, 2018

    

    BojanJurca

    on Sep 2, 2018 via email

    ContributorAuthor

    More actions

    After reinstalling Arduino it works. Thank you! V V ned., 2. sep. 2018 ob 16:09 je oseba Frank Hessel < notifications@github.com> napisala:

    …

    I can build the project without any problems in the Arduino IDE. Could you provide me with some additional info? I think being able to reproduce your problem will make it easier to find its cause, rather than randomly changing some includes and let you try again and again. Did you use the latest version of arduino-esp32 <https://github.com/espressif/arduino-esp32>? Which OS do you use? Which version of the Arduino IDE? If you just want to have HTTP/HTTPS in parallel, without the middleware feature, you can work with commit c5d8a1e <https://github.com/fhessel/esp32_https_server/tree/c5d8a1e28c39ddac6f090c9365bcd48a9879c81a> for now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AouyrRN67LQnM520MVi9-_e06tyPyuMQks5uW-aBgaJpZM4WWPkB> .