Skip to content

Fix Chrome 49 - #95

Closed
LinusU wants to merge 1 commit into
feross:masterfrom
LinusU:chrome-49-fix
Closed

LinusU wants to merge 1 commit into
feross:masterfrom
LinusU:chrome-49-fix

Conversation

@LinusU

@LinusU LinusU commented Jan 13, 2016

Copy link
Copy Markdown
Contributor

See #94, this may or may not be the best approach. At least it works :)

@nolanlawson

Copy link
Copy Markdown
Collaborator

Thanks for the PR, but #94 (comment) says the bug is fixed in Chrome itself, and I can confirm that the tests all pass in Chrome 49.0.2623.0 canary (64-bit, Mac OS X). Closing unless you still think this is an issue, thanks! :)

@LinusU

LinusU commented Jan 17, 2016

Copy link
Copy Markdown
Contributor Author

Great!

@LinusU
LinusU deleted the chrome-49-fix branch January 17, 2016 10:38
@littledan

Copy link
Copy Markdown
Contributor

It'd be great if we could fix this bug in this repo as well. The ES2016 draft spec mandates the behavior that Chrome 49 tries out. Turns out it's not web-compatible yet (due to this particular library and possibly nothing else), but I think it's the most sensible semantics long-term. It'd be great if we could do something in this library so that the web can get the better TypedArray subclassing semantics within a few years.

@LinusU

LinusU commented Jan 19, 2016

Copy link
Copy Markdown
Contributor Author

It probably have to be discussed in Node.js as well, but I think that it's sensible to allow new Buffer(buffer, start, end) to create a new slice of another buffer. I'm all for making buffer as similar to typed arrays as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants