Repository navigation
Conversation
Author
|
Closing as a duplicate of #44. I missed the closed PR during screening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42.
An
io.Copythat produces no bytes can leave net/http's status uncommitted. The ReadFrom hook currently marks the header written anyway, so a subsequent 502 or 204 is captured as 200.Only mark the header written when ReadFrom reports positive progress. Add local HTTP server regressions for empty EOF and an immediate reader error, plus a nonempty-copy control. The tests compare both the client's response status and captured metrics; the two zero-byte cases fail on master.
make ci(including wrapper regeneration and race tests),go vet ./..., gofmt andgit diff --checkpass on Go 1.26.10. Generated wrappers are unchanged.