Skip to content

[CDTOOL-1717] Add support for the GCS Logging public-key flag - #1925

Open
rcaril wants to merge 2 commits into
mainfrom
rcaril/CDTOOL-1717-add-support-for-public-key-for-gcslogging
Open

rcaril wants to merge 2 commits into
mainfrom
rcaril/CDTOOL-1717-add-support-for-public-key-for-gcslogging

Conversation

@rcaril

@rcaril rcaril commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Change summary

This PR adds support for the GCS Logging public-key flag.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Are there any considerations that need to be addressed for release?

This PR is pending on the release of fastly/go-fastly#881, tests will fail accordingly prior.

@rcaril
rcaril marked this pull request as ready for review October 2, 2026 16:24
@rcaril
rcaril requested a review from a team as a code owner October 2, 2026 16:24
@rcaril
rcaril requested a review from kpfleming October 2, 2026 16:24
@rcaril

rcaril commented Oct 2, 2026 •

Copy link
Copy Markdown
Member Author

Confirmed with local testing that the flag correctly updates and retrieves a Public Key for a given GCS endpoint.

@kpfleming kpfleming changed the title [CDTOOL-1717] Add support for the GCS Logging public-key" flag [CDTOOL-1717] Add support for the GCS Logging public-key flag Oct 2, 2026
@kpfleming

Copy link
Copy Markdown
Member

I'm guessing this needs a go-fastly release before the linter checks will succeed, right?

@rcaril

rcaril commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

I'm guessing this needs a go-fastly release before the linter checks will succeed, right?

Yup, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants