Repository navigation
Conversation
Author
|
I'm withdrawing this small, unsolicited TOML encoder change while reducing my open PR backlog. The branch is retained; this is not a claim that the underlying behavior is already fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOMLHandler.export accepts keyword options but drops them before calling toml.dumps. As a result, passing TomlPathlibEncoder still writes values such as PurePosixPath('assets/logo.svg') into metadata instead of the intended path string. Forward the export options to toml.dumps, matching the YAML and JSON handlers.
Tests cover direct handler export and post round trips with POSIX and Windows path values. The direct export assertion and both round-trip cases fail before the fix. With the fix, all 69 tests and 2 subtests pass using the CI pytest command with doctests, Python 3.12.11, toml 0.10.2 and pyaml 26.7.0. Mypy passes all 4 source files. Local testing was on macOS; the full Python/OS matrix has not been run.
Prepared with OpenAI Codex assistance.