Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

Modified on TextField - EmptyText Config #1091

Closed

Description

@fabriciomurta

Details:

6.0.0
default value is null
6.0.1
default value is ’’

UPDATE by @DaniilVeriga:

Breaking change:
TextFieldBase's .EmptyText is null by default. Now, the property might require a check on null.

Activity

  1. added this to the milestone on Dec 3, 2015
  2. fabriciomurta commented on Dec 17, 2015

    @fabriciomurta
    Author

    I believe this change requires no changes in source code. But as @DaniilVeriga has reopened a couple issues I closed thinking so, i'm forwarding him this issue so he can double-check.

  3. DaniilVeriga commented on Dec 17, 2015

    @DaniilVeriga

    Agree, that is not actual. So, invalid.

  4. fabriciomurta commented on Dec 17, 2015

    @fabriciomurta
    Author

    As we raised afterwards:

    • Set default value on attribute to null to let an empty string emitted
    • Change comment description from Default: null to Default: ''.
  5. DaniilVeriga commented on Jan 18, 2016

    @DaniilVeriga

    The commit caused #1232.

  6. DaniilVeriga commented on Jan 18, 2016

    @DaniilVeriga

    Decided to revert the commit, because it can break the logic in many places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions