Repository navigation
ci: run engine tests in parallel and put the Windows limit back to 40… - #384
Merged
itsskofficial merged 1 commit intoOct 15, 2026
Merged
Conversation
n-o-t-mugen
requested review from
Kabeer2004 and
itsskofficial
as code owners
October 15, 2026 15:03
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
itsskofficial
approved these changes
Oct 15, 2026
itsskofficial
left a comment
Contributor
There was a problem hiding this comment.
Thanks @n-o-t-mugen, great find, and a clean fix. The Windows engine job went from about 40 minutes to 18 (2176 passed, 2 skipped), and Ubuntu from 6.5 to under 4. Running in parallel with no test changes is the best outcome. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows engine job took 35 to 43 minutes against about 6 on Ubuntu. No single test causes it: the time comes from app start-up (SQLite disk flushes on NTFS), a one-time litellm import, real browsers and processes, and a slow, variable runner.
This runs the engine tests in parallel with pytest-xdist (
-n auto) and sets the limit back to 40 minutes. The tests already isolate their home folder, keychain and ports, so no test changes were needed.Closes #377
How I tested it
On Windows with CI's settings:
-n auto: 2175 passed in about 2 minutes, down from about 11. One rare failure intest_mailbox_transportdidn't reproduce in 6 more stress runs.ruff check: clean.This PR's CI run will confirm the Windows time is under 20 minutes.
Checklist
pytestpasses locally, in one process and in parallelruff check sentient testsis cleanSummary by CodeRabbit