Repository navigation
collatz-conjecture: Add parameter to placeholder file - #691
Merged
Merged
Conversation
ilya-khadykin
suggested changes
Oct 5, 2017
ilya-khadykin
left a comment
ilya-khadykin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR
Please see my comment below
| @@ -1,2 +1,2 @@ | |||
| def collatz_steps(): | |||
| def collatz_steps(n): | |||
Contributor
There was a problem hiding this comment.
I like number better than n because it is too ambiguous and we as programmers should avoid such names,
Do you agree?
Contributor
Author
There was a problem hiding this comment.
Yeah I suppose it is more clear, and regarding my previous stuff about it matching the readme's, I think in this case n == number is pretty clear
Contributor
|
Thanks, @smt923! You can find this Python style guide from Google helpful https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552, I decided on
ninstead ofnumberthis time as it matches the README which calls the integer n