Repository navigation
Update word count to match canonical tests - #519
Closed
matthewmorgan wants to merge 1 commit into
Closed
matthewmorgan wants to merge 1 commit into
matthewmorgan wants to merge 1 commit into
Conversation
matthewmorgan
force-pushed
the
word-count
branch
from
September 5, 2017 23:31
18123b0 to
b0dd9c1
Compare
matthewmorgan
force-pushed
the
word-count
branch
from
September 5, 2017 23:34
b0dd9c1 to
387dfd3
Compare
Contributor
|
This quote stuff is somehow overcomplicating this otherwise simple exercise. I agree that a regex is the best solution in this case ... otherwise one would have to write a lot just to handle the special cases. |
Author
|
@behrtam yes, the quote thing is thorny. Solving the exercise was trivial except for that. |
Contributor
|
While implementing this (or rather improving) example solution for this exercise for Thanks for the PR, @matthewmorgan |
ilya-khadykin
approved these changes
Sep 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #445
The regex is not my favorite, but it gets the job done. Also, the tests now match the canonical data.
I also took the liberty of skipping all but the first test. If #518 gets merged, these tests will run in CI ;)