Skip to content

Update word count to match canonical tests - #519

Closed
matthewmorgan wants to merge 1 commit into
exercism:masterfrom
matthewmorgan:word-count
Closed

matthewmorgan wants to merge 1 commit into
exercism:masterfrom
matthewmorgan:word-count

Conversation

@matthewmorgan

@matthewmorgan matthewmorgan commented Sep 5, 2017 •

Copy link
Copy Markdown

Closes #445

The regex is not my favorite, but it gets the job done. Also, the tests now match the canonical data.

I also took the liberty of skipping all but the first test. If #518 gets merged, these tests will run in CI ;)

@behrtam

behrtam commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

This quote stuff is somehow overcomplicating this otherwise simple exercise. I agree that a regex is the best solution in this case ... otherwise one would have to write a lot just to handle the special cases.

@matthewmorgan

Copy link
Copy Markdown
Author

@behrtam yes, the quote thing is thorny. Solving the exercise was trivial except for that.

@ilya-khadykin

Copy link
Copy Markdown
Contributor

While implementing this (or rather improving) example solution for this exercise for bash track I simply ignored the case with ' from canonical-data.json
So, it isn't necessary to include all the tests, but it's generally a good idea

Thanks for the PR, @matthewmorgan

@matthewmorgan
matthewmorgan deleted the word-count branch September 8, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants