Skip to content

triangle: update tests to v1.2.1 (#1757) #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccandless merged 1 commit into from
Apr 29, 2019
Merged

triangle: update tests to v1.2.1 (#1757) #1769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions exercises/triangle/triangle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,65 +3,65 @@
from triangle import is_equilateral, is_isosceles, is_scalene


# Tests adapted from `problem-specifications//canonical-data.json` @ v1.2.0
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.2.1

class is_equilateralTests(unittest.TestCase):
def test_true_if_all_sides_are_equal(self):
def test_all_sides_are_equal(self):
self.assertIs(is_equilateral([2, 2, 2]), True)

def test_false_if_any_side_is_unequal(self):
def test_any_side_is_unequal(self):
self.assertIs(is_equilateral([2, 3, 2]), False)

def test_false_if_no_sides_are_equal(self):
def test_no_sides_are_equal(self):
self.assertIs(is_equilateral([5, 4, 6]), False)

def test_false_if_all_sides_are_zero(self):
def test_all_zero_sides_is_not_a_triangle(self):
self.assertIs(is_equilateral([0, 0, 0]), False)

def test_sides_may_be_floats(self):
self.assertIs(is_equilateral([0.5, 0.5, 0.5]), True)


class is_isoscelesTests(unittest.TestCase):
def test_true_if_last_two_sides_are_equal(self):
def test_last_two_sides_are_equal(self):
self.assertIs(is_isosceles([3, 4, 4]), True)

def test_true_if_first_two_sides_are_equal(self):
def test_first_two_sides_are_equal(self):
self.assertIs(is_isosceles([4, 4, 3]), True)

def test_true_if_first_and_last_sides_are_equal(self):
def test_first_and_last_sides_are_equal(self):
self.assertIs(is_isosceles([4, 3, 4]), True)

def test_is_equilateral_triangles_are_also_is_isosceles(self):
def test_equilateral_triangles_are_also_isosceles(self):
self.assertIs(is_isosceles([4, 4, 4]), True)

def test_false_if_no_sides_are_equal(self):
def test_no_sides_are_equal(self):
self.assertIs(is_isosceles([2, 3, 4]), False)

def test_violation_of_triangle_inequality_is_not_isosceles_1(self):
def test_first_triangle_inequality_violation(self):
self.assertIs(is_isosceles([1, 1, 3]), False)

def test_violation_of_triangle_inequality_is_not_isosceles_2(self):
def test_second_triangle_inequality_violation(self):
self.assertIs(is_isosceles([1, 3, 1]), False)

def test_violation_of_triangle_inequality_is_not_isosceles_3(self):
def test_third_triangle_inequality_violation(self):
self.assertIs(is_isosceles([3, 1, 1]), False)

def test_sides_may_be_floats(self):
self.assertIs(is_isosceles([0.5, 0.4, 0.5]), True)


class is_scaleneTests(unittest.TestCase):
def test_true_if_no_sides_are_equal(self):
def test_no_sides_are_equal(self):
self.assertIs(is_scalene([5, 4, 6]), True)

def test_false_if_all_sides_are_equal(self):
def test_all_sides_are_equal(self):
self.assertIs(is_scalene([4, 4, 4]), False)

def test_false_if_two_sides_are_equal(self):
def test_two_sides_are_equal(self):
self.assertIs(is_scalene([4, 4, 3]), False)

def test_violation_of_triangle_inequality_not_is_scalene(self):
def test_may_not_violate_triangle_inequality(self):
self.assertIs(is_scalene([7, 3, 2]), False)

def test_sides_may_be_floats(self):
Expand Down