Repository navigation
alphametics: sync with problem-specifications - #1768
Merged
Merged
Conversation
sukovanej
force-pushed
the
master
branch
2 times, most recently
from
April 28, 2019 17:10
21eb207 to
a85eb8b
Compare
cmccandless
suggested changes
Apr 29, 2019
cmccandless
left a comment
cmccandless
left a comment
Contributor
There was a problem hiding this comment.
Please update the inline comments to reflect these changes
Contributor
Author
Sorry, what is meant by inline comments? 😅 Thanks |
cmccandless
suggested changes
Apr 30, 2019
| if rectest and len(rectest) > 0: | ||
| return rectest | ||
| # if no permutations are avaialble or no | ||
| # permutation gave the result return the empty dictionary |
Contributor
There was a problem hiding this comment.
Suggested change
| # permutation gave the result return the empty dictionary | |
| # permutation gave the result return None |
cmccandless
approved these changes
May 1, 2019
Contributor
|
Merged; thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1762
Update
alphameticsexercise so it matches canonical-data.json