Skip to content

luhn: update tests to v1.5.0 #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccandless merged 2 commits into from
Apr 29, 2019
Merged

luhn: update tests to v1.5.0 #1767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63b52e
luhn: update tests to v1.5.0 (#1758)
xitanggg Apr 26, 2019
bce42ed
Merge branch 'master' into master
xitanggg Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions exercises/luhn/luhn_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from luhn import Luhn


# Tests adapted from `problem-specifications//canonical-data.json` @ v1.4.0
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.5.0

class LuhnTest(unittest.TestCase):
def test_single_digit_strings_can_not_be_valid(self):
Expand All @@ -32,9 +32,6 @@ def test_invalid_credit_card(self):
def test_valid_number_with_an_even_number_of_digits(self):
self.assertIs(Luhn("095 245 88").is_valid(), True)

def test_valid_strings_with_a_non_digit_included_become_invalid(self):
self.assertIs(Luhn("055a 444 285").is_valid(), False)

def test_valid_strings_with_non_digit_added_at_end_become_invalid(self):
self.assertIs(Luhn("059a").is_valid(), False)

Expand All @@ -53,7 +50,10 @@ def test_more_than_a_single_zero_is_valid(self):
def test_input_digit_9_is_correctly_converted_to_output_digit_9(self):
self.assertIs(Luhn("091").is_valid(), True)

def test_strings_with_non_digits_is_invalid(self):
def test_using_ascii_value_for_non_doubled_non_digit_isnot_allowed(self):
self.assertIs(Luhn("055b 444 285").is_valid(), False)

def test_using_ascii_value_for_doubled_non_digit_isnot_allowed(self):
self.assertIs(Luhn(":9").is_valid(), False)

def test_is_valid_can_be_called_repeatedly(self):
Expand Down